[PATCH] CIFS: fix structurally dead code in smb311_posix_mkdir

[Paulo Alcantara]

Reviewed-by: Paulo Alcantara <palcantara at suse.de>

On June 21, 2018 10:35:23 AM GMT-03:00, "Gustavo A. R. Silva" <gustavo at embeddedor.com> wrote:
>Code at line: 1950: rc = -EIO; is unreachable. Hence, the function
>returns rc with a value of zero and, this is not the actual intention
>of this particular piece of code.
>
>Fix this by placing the goto instruction just after the update to rc.
>
>Addresses-Coverity-ID: 1470124 ("Structurally dead code")
>Fixes: 5539e9b24a38 ("CIFS: fix memory leak and remove dead code")
>Signed-off-by: Gustavo A. R. Silva <gustavo at embeddedor.com>
>---
> fs/cifs/smb2pdu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
>index 062a2a5..c9489b1 100644
>--- a/fs/cifs/smb2pdu.c
>+++ b/fs/cifs/smb2pdu.c
>@@ -1946,8 +1946,8 @@ int smb311_posix_mkdir(const unsigned int xid,
>struct inode *inode,
> 	if (ses && (ses->server))
> 		server = ses->server;
> 	else {
>-		goto err_free_path;
> 		rc = -EIO;
>+		goto err_free_path;
> 	}
> 
> 	/* resource #2: request */
>-- 
>2.7.4
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-cifs"
>in
>the body of a message to majordomo at vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.