Patch Fix JSON API

Andrew Bartlett abartlet at samba.org
Tue Jul 24 20:57:31 UTC 2018


On Tue, 2018-07-24 at 13:30 -0700, Jeremy Allison via samba-technical
wrote:
> On Wed, Jul 25, 2018 at 06:59:00AM +1200, Gary Lockyer wrote:
> > Hopefully the final patch set, have added _WARN_UNUSED_RESULT_ to the
> > function prototypes.
> > 
> > Could I please get a review on this.
> 
> Will do asap Gary - thanks !
> 
> Jeremy.

Everything except:

[PATCH 3/7] audit logging  tests: Only run JSON tests in ad dc

Reviewed-by: Andrew Bartlett <abartlet at samba.org>

(The 'none' environment is built in autobuild with the AD DC, and runs
many other tests.  We don't want to actually start the DC for unit
tests). 

Jeremy,

As you called for the change I'll look forward to your comments.

Thanks,

Andrew Bartlett
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list