[PATCH] don't build AD DC-specific dns and dsdb modules without AD DC

[Günther Deschner]

Hi,

I pushed the new patchset along with all RB+s and created a new bug to
track the backport.

Cheers,
Guenther


On 21/07/18 12:40, Alexander Bokovoy via samba-technical wrote:
> On pe, 20 heinä 2018, Jeremy Allison wrote:
>> On Fri, Jul 20, 2018 at 02:43:40PM -0700, Jeremy Allison via samba-technical wrote:
>>> On Fri, Jul 20, 2018 at 01:01:49PM +0300, Alexander Bokovoy via samba-technical wrote:
>>>> Hi,
>>>>
>>>> small patchset to make sure we don't build packages which couldn't be
>>>> used without AD DC when no AD DC is compiled in.
>>>
>>> LGTM. Thanks Alexander. RB+ and pushed !
>>
>> Sorry Alexander, failing in autobuild with:
>>
>>    samba-systemkrb5: [test] failed 'make test FAIL_IMMEDIATELY=1 TESTS='--include-env=ktest'' with status 2
>>
>> [17(19)/19 at 9s] samba3.blackbox.smbclient_krb5 new ccache -e(ktest:local)
>> [18(20)/19 at 9s] samba3.blackbox.smbclient_large_file -e krb5(ktest:local)
>> [19(22)/19 at 13s] samba.tests.ntlmdisabled.python(ktest)(ktest)
>> Traceback (most recent call last):
>>   File "/memdisk/jra/a/b657055/samba-systemkrb5/source4/scripting/bin/subunitrun", line 42, in <module>
>>     from samba.tests.subunitrun import TestProgram, SubunitOptions
>>   File "bin/python/samba/tests/__init__.py", line 41, in <module>
>>     from samba.samdb import SamDB
>>   File "bin/python/samba/samdb.py", line 31, in <module>
>>     from samba import dsdb, dsdb_dns
>> ImportError: cannot import name dsdb
>> command: PYTHONPATH=$PYTHONPATH:/memdisk/jra/a/b657055/samba-systemkrb5/python/samba/tests python /memdisk/jra/a/b657055/sam
>> +ba-systemkrb5/source4/scripting/bin/subunitrun  $LOADLIST ntlmdisabled 2>&1  | /memdisk/jra/a/b657055/samba-systemkrb5/self
>> +test/filter-subunit --fail-on-empty --prefix="samba.tests.ntlmdisabled.python(ktest)." --suffix="(ktest)"
>> expanded command: PYTHONPATH=/memdisk/jra/a/b657055/samba-systemkrb5/bin/python:/memdisk/jra/a/b657055/samba-systemkrb5/pyth
>> +on/samba/tests python /memdisk/jra/a/b657055/samba-systemkrb5/source4/scripting/bin/subunitrun  $LOADLIST ntlmdisabled 2>&1
>> +  | /memdisk/jra/a/b657055/samba-systemkrb5/selftest/filter-subunit --fail-on-empty --prefix="samba.tests.ntlmdisabled.pyth
>> +on(ktest)." --suffix="(ktest)"
>> ERROR: Testsuite[samba.tests.ntlmdisabled.python(ktest)(ktest)]
>> REASON: Exit code was 1
> Thanks, Jeremy. This is due to us using samba.tests Python library for
> both Samba AD DC-enabled and disabled tests. An easiest change is simply
> to not fail when SamDB couldn't be imported -- in those test scenarious
> we aren't callling to SamDB anyway.
> 
> A pipeline https://gitlab.com/samba-team/devel/samba/pipelines/26220496
> demonstrates that it is indeed true.
> 
> New patchset is attached.
> 


-- 
Günther Deschner                    GPG-ID: 8EE11688
Red Hat                         gdeschner at redhat.com
Samba Team                              gd at samba.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180724/f6307d8e/signature.sig>