[RFC PATCH v3 3/5] lib/audit_logging: avoid freeing unallocated json value

Philipp Gesang philipp.gesang at intra2net.com
Thu Jul 12 07:04:07 UTC 2018


json_free() has no effect on the empty json value so the call is
redundant.

Signed-off-by: Philipp Gesang <philipp.gesang at intra2net.com>
---
 lib/audit_logging/audit_logging.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/audit_logging/audit_logging.c b/lib/audit_logging/audit_logging.c
index d5fbad086d4..04eeaff011a 100644
--- a/lib/audit_logging/audit_logging.c
+++ b/lib/audit_logging/audit_logging.c
@@ -981,7 +981,6 @@ struct json_object json_get_array(
 	if (json_is_invalid(object)) {
 		DBG_ERR("Invalid JSON object, unable to get array [%s]\n",
 			name);
-		json_free(&array);
 		return array;
 	}
 
-- 
2.13.6




More information about the samba-technical mailing list