[PATCH] make flapping smbcontrol test more informative
Ralph Böhme
slow at samba.org
Sun Feb 25 09:35:05 UTC 2018
On Sun, Feb 25, 2018 at 09:07:06PM +1300, Douglas Bagnall via samba-technical wrote:
> And then I thought: with multi-process fork-on-demand LDAP, we should
> expect a race between listing the processes and pinging them. They
> disappear all the time.
>
> processes = self.msg_ctx.irpc_all_servers()
> for p in processes:
> for id in p.ids:
> if p.name != "samba":
> self.check_run("%s %d %s" % (COMMAND, id.pid, PING),
> msg="trying to ping %s" % p.name)
>
> so I was wrong here:
>
> >>> This is a canary, I suspect -- the test itself is sound (sort of),
>
> the test is not sound.
hehe, ouch! Good catch! :)
-slow
--
Ralph Boehme, Samba Team https://samba.org/
Samba Developer, SerNet GmbH https://sernet.de/en/samba/
More information about the samba-technical
mailing list