Possible issue in AD DC LSA server in master (was: Re: [PATCH] LMDB ...)

[Andrew Bartlett]

On Thu, 2018-04-12 at 11:47 +1200, Andrew Bartlett wrote:
> On Thu, 2018-04-12 at 11:40 +1200, Douglas Bagnall wrote:
> > On 10/04/18 19:19, Andrew Bartlett via samba-technical wrote:
> > > I've seen this on a master build, so it is just happening without these
> > > patches, but I also have a patch to address the issue by locking the
> > > init() hook. 
> > > 
> > > I have them in this branch:
> > > 
> > > https://gitlab.com/catalyst-samba/samba/commits/lmdb-pre-7
> > 
> > I have reviewed these ones and they LGTM.
> 
> Thanks!  It will be good to get these in.  
> 
> I'll autobuild these later today.

So, that autobuild failed with:

> [133(711)/525 at 10m56s] samba3.rpc.lsa.lookupsids(ad_dc)
> smbtorture 4.9.0pre1-DEVELOPERBUILD
> Using seed 1523610756
> UNEXPECTED(failure): samba3.rpc.lsa.lookupsids.lsa.LookupSidsReply(ad_dc)
> REASON: Exception: Exception: ../source4/torture/rpc/lsa_lookup.c:400: names.names[0].name.string was , expected S-1-5-21-1111111111-2222222222-3333333333-512: unexpected names[0].string
> 
> FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites)

And I mentioned before that I got one LSA failure on the branch up to:

commit cb607346d3c7c662343b0eae69e43eaa6358c188
Author: Gary Lockyer <gary at catalyst.net.nz>
Date:   Tue Mar 13 16:43:54 2018 +1300

    ldb-samba: require pid match for cached ldb
    
    Signed-off-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

> Testing OpenPolicy2
> UNEXPECTED(failure): samba4.rpc.altercontext on ncalrpc with seal,padcheck.altercontext(ad_dc_ntvfs:local)
> REASON: Exception: Exception: ../source4/torture/rpc/lsa.c:188: status was NT_STATUS_CONNECTION_RESET, expected NT_STATUS_CONNECTION_DISCONNECTED: OpenPolicy2 failed

(but wrote it off as I also got about 10 successes on branches with
that series in it). 

This is fishy, as Joe yesterday got this in travis CI on master:

> Testing LookupSids
> ndr_pull_error(1): Bad array size - got 0 expected 8
> 
> UNEXPECTED(failure): samba3.rpc.lsa.privileges.lsa.Privileges(ad_dc)
> REASON: Exception: Exception: ../source4/torture/rpc/lsa.c:774: dcerpc_lsa_LookupSids_r(b, tctx, &r) was NT_STATUS_ARRAY_BOUNDS_EXCEEDED, expected NT_STATUS_OK: LookupSids failed
> 
> FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites)

If anybody has any insights or suggestions please don't hesitate to
investigate.

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba