[RFC] incorrect dosmode on stream associated with dir

Jeremy Allison jra at samba.org
Wed Apr 11 02:30:33 UTC 2018


On Wed, Apr 11, 2018 at 02:14:03AM +0200, Timur I. Bakeyev wrote:
> 
>  	smb_fname->st.st_ex_mode &= ~S_IFMT;
> +	smb_fname->st.st_ex_mode &= ~S_IFDIR;
> 
> 
> Can be written as:
> 
>  	smb_fname->st.st_ex_mode &= ~(S_IFMT | S_IFDIR);
> 
> I believe.

Yes I know - I first considered that. It's not as clear IMHO.

As can be seen by this bug, clarity *matters* :-).



More information about the samba-technical mailing list