[PATCH] Fix coverity issue in ctdb

Amitay Isaacs amitay at gmail.com
Thu Sep 7 01:43:49 UTC 2017


Hi Volker,

On Wed, Sep 6, 2017 at 4:03 PM, Volker Lendecke <Volker.Lendecke at sernet.de>
wrote:

> On Wed, Sep 06, 2017 at 11:34:32AM +1000, Amitay Isaacs via
> samba-technical wrote:
> > Hi,
> >
> > Please review and push.
>
> Are you sure that fixes 1414746? I don't fully understand the CID, but
> my impression is that the the overflow is not from assigning ssize_t
> to int.
>
>
You are correct. It's not the fix for actual CID.  Actual CID is the
overflow of db_flags.

Here are the modified patches.

- first patch is fixing the overflow (int --> ssize_t)
- second patch should fix the CID

Amitay.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ctdb.patch
Type: text/x-patch
Size: 2831 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170907/c22dfe1c/ctdb.bin>


More information about the samba-technical mailing list