[PATCH] libcli/smb: Parse primary domain from session setup

[Samuel Cabrero]

Hi Andrew,

I have written the test but maybe there is a better place for it. After
metze's comments, I will file a new bug for backporting if the team
agrees that the patch is correct.

Cheers.

On Mon, 2017-10-30 at 15:58 +1300, Andrew Bartlett wrote:
> On Tue, 2017-10-24 at 10:56 +1300, Andrew Bartlett via samba-
> technical
> wrote:
> > On Mon, 2017-10-23 at 14:12 +0200, Samuel Cabrero via samba-
> > technical
> > wrote:
> > > Hi,
> > > 
> > > I still have this patch on the queue, I sent it some time ago.
> > 
> > This looks good to me.  Could we have a test so we don't break this
> > again?
> 
> Any chance you can write a test for this?
> 
> > Also, please file a bug for backport.
> > 
> > Metze: Can I get some more comment from you on this?  You made
> > comments
> > about some of the parsing routines working only by luck here:
> > https://bugzilla.samba.org/show_bug.cgi?id=12824
> > 
> > Was there an intentional reason this support was lost?
> 
> Can I please get a comment on this patch from the broader team?
> 
> Thanks,
> 
> Andrew Bartlett
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-libcli-smb-Parse-primary-domain-from-session-setup.patch
Type: text/x-patch
Size: 3708 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20171030/f036d77f/0002-libcli-smb-Parse-primary-domain-from-session-setup.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-selftest-Add-test-to-check-extracted-values-from-SMB.patch
Type: text/x-patch
Size: 5215 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20171030/f036d77f/0001-selftest-Add-test-to-check-extracted-values-from-SMB.bin>