[PATCH] Fix the build of process_prefork.c

Andreas Schneider asn at cryptomilk.org
Thu Oct 19 19:05:36 UTC 2017


On Thursday, 19 October 2017 21:02:31 CEST Andrew Bartlett wrote:
> On Thu, 2017-10-19 at 11:47 -0700, Jeremy Allison via samba-technical
> 
> wrote:
> > On Thu, Oct 19, 2017 at 05:31:31PM +0200, Andreas Schneider via samba-
technical wrote:
> > > Hi,
> > > 
> > > Samba doesn't build for me since this has been committed. The error is:
> > > 
> > > error: implicit declaration of function ‘getpgrp’; did you mean ‘getpt’?
> > > [-
> > > Werror=implicit-function-declaration]
> > > 
> > > unistd.h is missing for that function. The attached patch fixes it.
> > > 
> > > 
> > > Review and push appreciated.
> > 
> > LGTM. RB+ and pushed.
> > 
> > > 	Andreas
> 
> Once upon a time we had a rule not to include system headers directly,
> but to bring this in via the lib/replace/system/ headers, eg
> <system/filesys.h>.

Wouldn't then system/passwd.h be the correct header?

> It doesn't seem to have made README.Coding however.
> 
> Thanks,
> 
> Andrew Bartlett


-- 
Andreas Schneider                   GPG-ID: CC014E3D
www.cryptomilk.org                asn at cryptomilk.org



More information about the samba-technical mailing list