Resend: Patch to implement utimes in smbclient along with a test

Richard Sharpe realrichardsharpe at gmail.com
Mon Oct 16 22:38:47 UTC 2017


On Mon, Oct 16, 2017 at 2:03 PM, Jeremy Allison <jra at samba.org> wrote:
> On Fri, Sep 22, 2017 at 11:54:49AM -0700, Jeremy Allison via samba-technical wrote:
>> On Thu, Sep 21, 2017 at 07:22:19PM -0700, Richard Sharpe via samba-technical wrote:
>> > > editor shows red for that new line.
>> >
>> > OK, fixed that one as well.
>>
>> A few fixes needed:
>>
>> 1). d_printf("setmode <filename> <create-time> <access-time> "
>> should be: d_printf("utimes...").
>>
>> 2). Split the test into a separate patch to go in after
>> the client.c fix (I find that easier to back-port if
>> needed).
>>
>> 3). Needs a docs-xml update for smbclient describing
>> the new "utimes" command.
>>
>> I can do these for you next week if you're busy, but
>> I think these need doing before this can go in.
>
> Here's the version I'd like to ship. Richard, are
> you happy with this ?

Looks good to me. Thanks.

-- 
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)



More information about the samba-technical mailing list