[PATCH] vfs_retention: add this module to make a share read only with a special time period.

Volker Lendecke Volker.Lendecke at SerNet.DE
Tue Oct 10 12:11:44 UTC 2017


On Tue, Oct 10, 2017 at 11:46:06AM +0000, Li, Dan wrote:
> Hi, Volker
> 
> Thanks for your comments!
> 
> > Can you take a look at README.Coding in the Samba source directory?
> > There's a lot of formatting issues with the code.
> OK. I deal with the format issues, please check the attachments.
> Should I squash all the 3 patches together?

Maybe. At least the first and third one belong together.

> > Then in your second patch: This should not be necessary. What fails exactly?
> It failed when build the samba-static task. Pls check details from the following link:
> https://travis-ci.org/samba-team/samba/jobs/264593495

I guess the right way to solve this would be to make getdate a
subsystem or library on its own.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de



More information about the samba-technical mailing list