[PATCH] Ensure default SMB_VFS_GETWD() call can't return a partially completed struct smb_filename.

Ralph Böhme slow at samba.org
Wed Oct 4 08:05:34 UTC 2017


On Tue, Oct 03, 2017 at 12:43:48AM +0000, Jeremy Allison wrote:
> When I converted SMB_VFS_GETWD() to return a struct smb_filename *
> I messed up and allowed it to return a partially constructed
> struct if the underlying sys_getwd() returned NULL (i.e. I didn't immediately
> return NULL if sys_getwd() failed).
> 
> Found whilst investigating a different bug, but this is a pretty
> obvious fix. Only affects 4.7 as that contains the struct smb_filename *
> VFS changes.
> 
> Please review and push for master if happy !

pushed.

-slow



More information about the samba-technical mailing list