[PATCHES] s3-sysacls - modify SMB_ACL_PERMSET_T to be a mode_t (possible HPUX fix)

[Uri Simchoni]

On 11/28/2017 08:08 AM, Arjit Gupta wrote:
> HI Uri,
> 
> Thanks for providing the patch.
> 
> We did below change and it is working fine.
> 
> diff ./pidl/lib/Parse/Pidl/Typelist.pm.bak ./pidl/lib/Parse/Pidl/Typelist.pm
> 87c87,89
> <         "mode_t"        => "uint32",
> ---
>> # on HP-UX mode_t is of uint16_t, so changed uint32 to uint16
>> #       "mode_t"        => "uint32",
>>         "mode_t"        => "uint16",
> 
> Is this change fine or should we port the patch provided by you.
> 

This change certainly fixes things for your system, but it cannot be
upstreamed (at least not as-is) because that would break Linux. The fix
I'm proposing hopefully fixes things without IDL changes.

If you can open a bugzilla bug, that would be great, and if you can test
my fix (I can make a fix that builds on your version of Samba) that
would be even better. But as I said - you're good to go with your fix too.

Thanks,
Uri.

> Arjit Kumar
> 9650104435
> 
> On Tue, Nov 28, 2017 at 11:09 AM, Uri Simchoni <uri at samba.org
> <mailto:uri at samba.org>> wrote:
> 
>     Hi,
> 
>     This patch set fixes clang picky-developer errors on FreeBSD around
>     POSIX acls. It possibly also fixes an hpux issue reported in
>     https://bugzilla.samba.org/show_bug.cgi?id=11490#c4
>     <https://bugzilla.samba.org/show_bug.cgi?id=11490#c4>
> 
>     I've solicited response on that bug in bugzilla - we need a bug report
>     and official verification in order to add a BUG: and backport, but even
>     without bug report, it fixes picky-developer on FreeBSD.
> 
>     The first patch is the real fix (both to warning and possible bug), and
>     the rest are cleanup patches (I suppose this can be further cleaned up
>     by removing return code and error checking from APIs that cannot fail,
>     and possibly by removing SMB_ACL_PERMSET_T altogether and using mode_t.
>     There seems to be no end to cleanup...)
> 
>     Review appreciated,
>     Uri.
> 
>