vfs_zfsacl.c: use of undeclared identifier 'ace'

[Ira Cooper]

You are both right.

If it isn't on Linux, it isn't well tested, IMHO.

I faced this all the time when I worked on similar projects to Youzhong.

So yes.... things can be checked in that break the build on *insert
non-linux os* here near trivially.

I remember having to clean it up every few months, back when I did that.

Thankfully, the core code tends to work well, even outside of Linux, or at
least it used to.

Thanks,

-Ira

On Mon, Nov 13, 2017 at 1:25 PM, Jeremy Allison via samba-technical <
samba-technical at lists.samba.org> wrote:

> On Sat, Nov 11, 2017 at 11:39:40PM +0000, Youzhong Yang via
> samba-technical wrote:
> > Thanks, it fixes the compilation error.
> >
> > I appreciate Samba team's efforts/contributions. But as an outsider,
> just a little bit concerned - it seems code change/fix is so easy to get
> into the system, without adequate review/testing.
>
> Not really. zfsacls are not shipped on the majority of
> platforms, so it's hard to have regression tests for code
> that most people can't compile.
>
> It's impossible to get compilation errors into mainline where regression
> tests ensure quality.
>
>