[PATCHES] GPO support for the AD DC (vers 5)

Andrew Bartlett abartlet at samba.org
Wed Nov 1 19:08:08 UTC 2017


On Thu, 2017-11-02 at 06:10 +1300, Andrew Bartlett via samba-technical
wrote:
> On Wed, 2017-11-01 at 11:01 -0600, David Mulder wrote:
> > Oh, sorry. It actually all came through in a single email (labeled one
> > of thirty). 
> 
> Sorry, didn't scroll down ;-)
> 
> > But it looks as though I missed a commit anyhow, since there
> > should be 31 commits, not 30.
> > Here is an attachment, and is posted to my github repo:
> > https://github.com/dmulder/samba/tree/garming-gpo-david-rebased
> 
> Thanks!

I've pushed it back to garming-gpo-david-rebased after some squashing.

The diff is:

diff --git a/libgpo/pygpo.c b/libgpo/pygpo.c
index 38844e5a43e..4f53981ec83 100644
--- a/libgpo/pygpo.c
+++ b/libgpo/pygpo.c
@@ -70,7 +70,7 @@ static PyObject *py_gpo_get_unix_path(PyObject *self, PyObject *args,
        TALLOC_CTX *frame = NULL;
        static const char *kwlist[] = {"cache_dir", NULL};
        struct GROUP_POLICY_OBJECT *gpo_ptr \
-               = pytalloc_get_type(self, struct GROUP_POLICY_OBJECT);
+               = (struct GROUP_POLICY_OBJECT *)pytalloc_get_ptr(self);
 
        if (!PyArg_ParseTupleAndKeywords(args, kwds, "|s", discard_const_p(char *, kwlist), &cache_dir)) {
                PyErr_SetString(PyExc_SystemError, "Failed to parse arguments to gpo_get_unix_path()");


I'll try to get this reviewed into master during the next little while.

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba







More information about the samba-technical mailing list