[PATCH] Messaging improvements and fixes needed for auth logging

Jeremy Allison jra at samba.org
Thu Mar 23 18:58:06 UTC 2017


On Fri, Mar 24, 2017 at 07:52:46AM +1300, Andrew Bartlett wrote:
> > Sorry, thought it was a pretty obvious fix. The
> > tests on top should make sure we don't regress here.
> 
> While entirely reasonable to split up, and we can differ on the API, I
> think we should keep the logic changes in the original patch. 
> 
> Otherwise I don't see how we delete names once the last user is de-
> registered.

Yeah, you're probably right, sorry. I'll restructure this so your
tests go in first + the knownfail, then the fix, then
the -knownfail. Once all the make tests pass I'll repost
for review. That should make sure we don't regress.



More information about the samba-technical mailing list