[PATCH] Messaging improvements and fixes needed for auth logging
Volker Lendecke
vl at samba.org
Thu Mar 23 17:52:49 UTC 2017
On Thu, Mar 23, 2017 at 08:56:52AM -0700, Jeremy Allison via samba-technical wrote:
> On Thu, Mar 23, 2017 at 04:36:02PM +0100, Volker Lendecke via samba-technical wrote:
> > On Tue, Mar 21, 2017 at 07:48:16AM +0100, Volker Lendecke wrote:
> > > On Tue, Mar 21, 2017 at 11:59:45AM +1300, Andrew Bartlett via samba-technical wrote:
> > > > I'll amend the commit messages, but the patches in the series I posted
> > > > here are (essentially) the unit tests for the bug in the server_id
> > > > database, because it was adding the tests for the bindings that found
> > > > the bug.
> > >
> > > Please make it obvious with two commits. First is the real bugfix,
> > > and second one would be the API change with a comment "make the API
> > > safer" or so. Then we can discuss the things separately.
> >
> > Attached is what I had in mind with "First is the real bugfix".
> >
> > Review appreciated!
>
> Yep, that's the direct fix. LGTM. Pushed with
> the added BUG: ref. in the commit message.
Shouldn't we give Andrew a chance to comment first?
Volker
More information about the samba-technical
mailing list