[PATCH] Solve issues with flapping patches

[Andrew Bartlett]

On Fri, 2017-06-30 at 14:28 +1000, Martin Schwenke wrote:
> On Fri, 30 Jun 2017 16:20:06 +1200, Andrew Bartlett
> <abartlet at samba.org> wrote:
> 
> > On Fri, 2017-06-30 at 14:09 +1000, Martin Schwenke via samba-
> > technical
> > wrote:
> > > Sorry if I'm wrong here.  I can happily live with occasional
> > > autobuild
> > > failures... but I find the constant failures very
> > > frustrating...   
> > 
> > That would leave the most critical components of the AD DC
> > untested,
> > which isn't acceptable either.
> 
> As I said, the tests can be switched back on by the developers who
> want
> to test that code.  So, all of your testing can run those tests.
> 
> The autobuild process is used as a gatekeeper for getting good
> code/tests into the tree.  It doesn't help you when I test critical
> components of the AC DC and flakiness causes my autobuilds to
> fail! You don't even notice it... but I do...  :-)

How about this to go with it then?

diff --git a/script/autobuild.py b/script/autobuild.py
index e4a52ee7ff5..1b265173ed0 100755
--- a/script/autobuild.py
+++ b/script/autobuild.py
@@ -69,7 +69,6 @@ tasks = {
                ("configure", "./configure " + ctdb_configure_params,
"text/plain"),
                ("make", "make all", "text/plain"),
                ("install", "make install", "text/plain"),
-               ("test", "make autotest", "text/plain"),
                ("check-clean-tree", "../script/clean-source-tree.sh",
"text/plain"),
                ("clean", "make clean", "text/plain") ],
 
I think we can both agree this is absurd, but removing tests is an
absurd answer to this problem.

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba