[PATCH] reduce churn-induced conflicts in selftest/knownfail and flapping

Andrew Bartlett abartlet at samba.org
Sun Jun 4 00:21:47 UTC 2017


On Sat, 2017-06-03 at 11:24 +1200, Douglas Bagnall via samba-technical
wrote:
> I wrote:
> 
> > > I generally like the idea, but can we keep the existing selftest/knownfail file
> > > in place and not move it into the knownfail.d directory? That would make it work
> > > like all the other kids like cron handle this.
> > 
> > I think the attached version does that.
> 
>   ^^^^^^^
> 
> But actually it didn't work, because you need the directories to exist, and to make
> the directories exist in git you need placeholders. So here's a version with README
> placeholders.
> 
> Douglas
> 
> > It doesn't complicate the selftest code as much as I feared and I can see the
> > benefit of not having to remember where knownfail moved to.
> > 
> > cheers,
> > Douglas
> > 

Thanks Douglas, in particular for the improved version, it is a nicer
solution, particularly for backports.

It is now in master!

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list