[PATCHSET] Add support for fall through attribute
Andrew Bartlett
abartlet at samba.org
Mon Dec 18 08:47:03 UTC 2017
On Wed, 2017-12-13 at 10:47 +0100, Andreas Schneider wrote:
> On Wednesday, 13 December 2017 10:24:13 CET Andrew Bartlett wrote:
> >
> > I'll have another go at it this week.
>
> Thank you very much!
>
> > I'm particularly concerned about the tldap change because it implies
> > there isn't a testsuite for it.
>
> source3/torture/torture.c see run_tldap()
>
> /* test search filters against rootDSE */
>
>
> There is a test but I don't see that this test is planned in selftest.
Can you fix that up, show that the change fixes a bug and re-submit?
In the meantime my plan is to review these again and merge everything
else, either allowing warnings for this file or not enabling the
warning globally (for now).
Thanks,
Andrew Bartlett
--
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical
mailing list