[PATCHES][BUG 13189] Fix coredump on failing chdir during logoff

[Andrew Bartlett]

On Fri, 2017-12-15 at 11:24 -0800, Jeremy Allison wrote:
> On Thu, Dec 14, 2017 at 01:06:13PM -0700, Christof Schmitt via samba-technical wrote:
> > On Thu, Dec 14, 2017 at 12:02:18PM +1300, Andrew Bartlett wrote:
> > > On Wed, 2017-12-13 at 15:50 -0700, Christof Schmitt wrote:
> > > > On Thu, Dec 14, 2017 at 11:07:00AM +1300, Andrew Bartlett wrote:
> > > > > On Wed, 2017-12-13 at 13:24 -0700, Christof Schmitt via samba-technical 
> > > > > wrote:
> > > > > 
> > > > > This looks great!  I love that you went to such effort to create an
> > > > > automated test for this!
> > > > 
> > > > Thanks. I wanted an easy way to trigger this problem, and it might be
> > > > useful in general to trigger errors for testing. Wrapping that in test
> > > > script was then a quick addition.
> > > > 
> > > > > > +       "SERVERCONFFILE",
> > > > > 
> > > > > This is the only part I don't think you need, you can use SMB_CONF_FILE
> > > > > for this as you are running with :local (that is essentially what
> > > > > :local does). 
> > > > 
> > > > Correct, i missed that part. Updated patches are attached.
> > > 
> > > I think we should we check that a panic would be detected.  I realise
> > > that is a real pain, but otherwise I fear a change to the logging would
> > > render the patch neutered. 
> > > 
> > > Just make the fault injection module also call panic directly. 
> > > 
> > > Then, finally, put the test first, with a knownfail, and then remove
> > > the knownfail with the fix.
> > > 
> > > To be clear, this is great, but if you can do this one last change I
> > > would appreciate it.
> > 
> > See attached patches for these changes.
> 
> Nice work Christof, thanks. RB+ and pushed !

I likewise reviewed and pushed it.  However autobuild fails, it needs
the attached fixup.  (I had meant to push it again with this folded in,
but clearly did not). 

Andrew Bartlett
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fixup-missing-static-decl.patch
Type: text/x-patch
Size: 800 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20171216/83c25837/0001-fixup-missing-static-decl.bin>