[PATCH] s3/mdssvc: missing assignment in sl_pack_float

[Jeremy Allison]

On Sun, Aug 27, 2017 at 09:10:41PM +0200, Ralph Böhme wrote:
> Hi!
> 
> Another one found by -Werror=maybe-uninitialized.
> 
> Please review&push if ok. Thanks!

LGMT. Pushed !


> From ebb6cdb5eec967810899995df4866ad5212512f0 Mon Sep 17 00:00:00 2001
> From: Ralph Boehme <slow at samba.org>
> Date: Sun, 27 Aug 2017 19:22:38 +0200
> Subject: [PATCH] s3/mdssvc: missing assignment in sl_pack_float
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> Spotted by -Werror=maybe-uninitialized:
> 
> ../source3/rpc_server/mdssvc/marshalling.c: In function ‘sl_pack_float’:
> ../source3/rpc_server/mdssvc/marshalling.c:171:11: error:
> ‘ieee_fp_union.w’ may be used uninitialized in this function
> [-Werror=maybe-uninitialized]
>   offset = sl_push_uint64_val(buf, offset, bufsize, ieee_fp_union.w);
> 
> Bug: https://bugzilla.samba.org/show_bug.cgi?id=12991
> 
> Signed-off-by: Ralph Boehme <slow at samba.org>
> ---
>  source3/rpc_server/mdssvc/marshalling.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/source3/rpc_server/mdssvc/marshalling.c b/source3/rpc_server/mdssvc/marshalling.c
> index 0a02f418722..976702c49d4 100644
> --- a/source3/rpc_server/mdssvc/marshalling.c
> +++ b/source3/rpc_server/mdssvc/marshalling.c
> @@ -164,6 +164,8 @@ static ssize_t sl_pack_float(double d, char *buf, ssize_t offset, size_t bufsize
>  		uint64_t w;
>  	} ieee_fp_union;
>  
> +	ieee_fp_union.d = d;
> +
>  	offset = sl_push_uint64_val(buf, offset, bufsize, sl_pack_tag(SQ_TYPE_FLOAT, 2, 1));
>  	if (offset == -1) {
>  		return -1;
> -- 
> 2.13.5
>