[PATCH] Port of samba.security Python module

Andrew Bartlett abartlet at samba.org
Tue Aug 8 04:38:11 UTC 2017


On Mon, 2017-08-07 at 16:48 +0200, Lumir Balhar via samba-technical
wrote:
> Hello.
> 
> Is there any problem with this patch? I've tried to rebase it to the 
> latest master and there is no conflict.
> 
> If the problem is that the module is unstested, could you please help
> me 
> to write some test?

We do always need more tests :-)

It doesn't look like a complex conversion however.  How about creating
an SD from SSDL, then testing it against a token (even an empty one). 
Add that to the python/samba/tests/security.py testsuite. 

That should confirm the C code still gets hit by the python code.

Thanks,

Andrew Bartlett
-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba







More information about the samba-technical mailing list