[PATCH] shadow_copy2: mount_point is valid only for locally mountable file-system

Rajesh Joseph rjoseph at redhat.com
Fri Sep 30 08:01:58 UTC 2016


shadow_copy2 currently assumes that all the underlying file-system are
mountable and
are mounted on samba server. But this may not be true for all cases, e.g.
GlusterFS is
accessed via libgfapi and is not mounted.

This can lead to connection failure if such file-systems are used along
with shadow_copy2.
The attached patch assume "/" as the default mount-point in such cases
instead of failing
the connect.

This may not be a complete fix because shadow_copy2_find_mount_point can
return wrong
mount_point if by coincidence the "connectpath" is actually present in the
local file-system.

I had a brief discussion on this with Michael, and we think that it might
be good if VFS layer
can tell if the underlying file-system is mountable or not.

It would be great to know what others think on this problem.

Thanks & Regards,
Rajesh
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-shadow_copy2-mount_point-is-valid-only-for-locally-m.patch
Type: text/x-patch
Size: 2037 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160930/c986fddb/0001-shadow_copy2-mount_point-is-valid-only-for-locally-m.bin>


More information about the samba-technical mailing list