[PATCHES] SMB2 client quota support
Volker Lendecke
vl at samba.org
Tue Sep 27 14:07:44 UTC 2016
On Tue, Sep 27, 2016 at 04:00:29PM +0200, Andreas Schneider wrote:
> On Monday, 26 September 2016 13:05:14 CEST Jeremy Allison wrote:
> > 1). Hate this reformatting... :-)
> >
> > [PATCH 07/19] s3-libsmb: make parse_user_quota_record() public
> >
> > -static bool parse_user_quota_record(const uint8_t *rdata,
> > - unsigned int rdata_count,
> > - unsigned int *offset,
> > - SMB_NTQUOTA_STRUCT *pqt)
> > +bool parse_user_quota_record(const uint8_t *rdata, unsigned int
> > rdata_count, + unsigned int *offset,
> > SMB_NTQUOTA_STRUCT *pqt)
> >
> > I much prefer the
> >
> > function(arg1
> > arg2,
> > arg3.
> > arg4)
> >
> > style. But that's just a personal thing :-).
> >
>
> If this isn't in our CodingStyle guideline, we should add it! We prefer this,
> so if you change an argument, you can directly see which argument changed in a
> patch.
Please make it such that we can align it with the (, not with the tabs
next to the (. There's editors around that do that for you :-)
Volker
More information about the samba-technical
mailing list