[PATCHES] SMB2 client quota support

Uri Simchoni uri at samba.org
Mon Sep 26 11:00:16 UTC 2016


On 09/22/2016 08:09 PM, Uri Simchoni wrote:
> Hi,
> 
> Strange things can happen in those jet-lagged nights.
> 
> The attached patch set fixes a few issues with current quota support
> code and then adds support for using smbcquotas with SMB2 and later
> protocols.
> 
> Unlike the server-side lack of support, I don't consider smb2 client
> quota to be a bugfix, but rather a feature, because a user can use tool
> A in SMB1 mode and tool B in SMB2 mode, whereas with the server, a mount
> dictates the protocol version of all operations, so if suddenly quota
> doesn't work that's a degradation.
> 
> I intend to follow up with fixes to the server as well, and some of the
> work here lays the ground work for that, but the patch has grown quite a
> bit so I decided to stop here and submit it.
> 
> I also upstreamed wireshark patches to dissect it all.
> 
> The first 5 patches are bugfixes and the rest is cleanup / adding the
> smb2 stuff. It can be squashed quite a bit since it's all around the
> same 3-4 files - I'm open to suggestions.
> 
> Review appreciated,
> Uri.
> 
There are three different bugfixes in this patch set, all tucked under
the same bug, and I've been asked to split them in to separate bugs.
This doesn't change the patch body, but does modify the BUG: header.

If reviewing the code, please don't push until this is fixed (I'll
correct the BUG header when issuing v2 of the patch set, or, if no v2 is
required, when pushing).
Thanks,
Uri.



More information about the samba-technical mailing list