[PATCHSET] Cleanup krb5_wrap and other kerberos stuff
Andrew Bartlett
abartlet at samba.org
Thu Sep 1 18:52:55 UTC 2016
On Wed, 2016-08-31 at 08:09 +0200, Andreas Schneider wrote:
> On Tuesday, 30 August 2016 17:01:11 CEST Andreas Schneider wrote:
> >
> > On Tuesday, 30 August 2016 15:51:03 CEST Andreas Schneider wrote:
> > >
> > > You can also find the patchset here:
> > >
> > > https://git.samba.org/?p=asn/samba.git;a=shortlog;h=refs/heads/ma
> > > ster-mit->; > kd c-ok
> >
> > I removed smb_krb5_free_error() because it depends which function
> > you need
> > to call. And example is https://git.samba.org/?p=asn/
> > samba.git;a=commitdiff;h=b2efe9d28b48c589241a4cec16204770c2c467c6
> >
> > Depending on the Kerberos impelementation
> > krb5_init_creds_get_error() returns an allocated pointer or just
> > fills a
> > structure. So the variable needs to be declared and passed
> > differently.
> >
>
> And too many brackets ... works with MIT Kerberos now.
Sorry, I didn't see that one at the time I was doing my review work.
Andrew Bartlett
--
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical
mailing list