[PATCH] samba-tool user add: new options and fix
SATOH Fumiyasu
fumiyas at osstech.jp
Tue Oct 11 08:41:09 UTC 2016
Hi,
On Tue, 13 Oct 2015 19:07:49 +0900,
Sergey Urushkin wrote:
> Hello, Marc!
I want this patchset. Could you review and commit it?
> Marc Muehlfeld писал 2015-10-12 21:49:
> > Hello Sergey,
> >
> > Am 08.10.2015 um 14:16 schrieb Sergey Urushkin:
> >> This simple patch adds new options to "samba-tool user add" command:
> >> * middle-name - allows specifying middleName
> >> * display-name - allows to manually specify displayName
> >>
> >> And Fixes "initials" option. Do not add dot at the end of initials
> >> attribute, like ADUC behaves (only add dot to displayName if not
> >> specified).
> >
> >
> > Thanks for the patch. Three comments from my side:
> > * Can you put the "initials fix" into a separate patch?
> > * Limit the line length to 80 characters
> > * Please add your Signed-off-by tag
> >
> Done. Please, review.
Regards,
--
-- Name: SATOH Fumiyasu @ OSS Technology Corp. (fumiyas @ osstech co jp)
-- Business Home: http://www.OSSTech.co.jp/
-- GitHub Home: https://GitHub.com/fumiyas/
-- PGP Fingerprint: BBE1 A1C9 525A 292E 6729 CDEC ADC2 9DCA 5E1C CBCA
More information about the samba-technical
mailing list