[PATCH] restructure messaging

Jeremy Allison jra at samba.org
Tue Oct 4 21:51:28 UTC 2016


On Mon, Oct 03, 2016 at 04:43:39PM -0700, Jeremy Allison wrote:
> On Mon, Oct 03, 2016 at 10:00:13AM -0700, Jeremy Allison wrote:
> > On Fri, Sep 30, 2016 at 08:26:47AM -0700, Volker Lendecke wrote:
> > > 
> > > Attached find a version that survived two autobuilds. Thanks to metze
> > > for some insight on tevent_fd, see patch 30/30 :-)
> > 
> > Just looked at that one - that's a clever use of flags being
> > zero'ed out :-).
> > 
> > I'm back in the office and alive (somewhat) again. I'll
> > review asap !
> 
> Up to patch 8/30... This is where things start to get
> get interesting (pthreadpool changes :-).
> 
> Hopefully will be done sometime tomorrow !

OK - Reviewed-by: Jeremy Allison <jra at samba.org>. Pushed.

I'd like to add some comments inside source3/lib/messages_dgm.c
once this goes in to explain *exactly* how the messaging
works for people who haven't reviewed the patchset and
might be wondering how the internals of this works, but
that's a patch that can go on top.

Impressive work !



More information about the samba-technical mailing list