[PATCH] Increase the OS version which spoolss announces
Jeremy Allison
jra at samba.org
Wed Nov 16 23:30:42 UTC 2016
On Wed, Nov 16, 2016 at 05:58:24PM +0100, Andreas Schneider wrote:
> Hello,
>
> the attached patch increases the spoolss OS version to:
>
> Windows Server 2003R2 SP2 (5.2.3790)
>
>
> Please review and push!
LGTM - pushed !
>
>
> Andreas
>
> --
> Andreas Schneider GPG-ID: CC014E3D
> Samba Team asn at samba.org
> www.samba.org
> From 4bdd092b8bfc521e2c2385a6e9a56754a5046cd7 Mon Sep 17 00:00:00 2001
> From: Andreas Schneider <asn at samba.org>
> Date: Wed, 9 Nov 2016 13:17:27 +0100
> Subject: [PATCH] s3:spoolss: Set default OS Version to Windows Server 2003 R2
> SP2
>
> BUG: https://bugzilla.samba.org/show_bug.cgi?id=12416
>
> Signed-off-by: Andreas Schneider <asn at samba.org>
> Reviewed-by: Guenther Deschner <gd at samba.org>
> ---
> source3/rpc_server/spoolss/srv_spoolss_nt.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/source3/rpc_server/spoolss/srv_spoolss_nt.c b/source3/rpc_server/spoolss/srv_spoolss_nt.c
> index ce073c2..c80d760 100644
> --- a/source3/rpc_server/spoolss/srv_spoolss_nt.c
> +++ b/source3/rpc_server/spoolss/srv_spoolss_nt.c
> @@ -2344,13 +2344,19 @@ static WERROR getprinterdata_printer_server(TALLOC_CTX *mem_ctx,
> enum ndr_err_code ndr_err;
> struct spoolss_OSVersion os;
>
> + /*
> + * Set the default OSVersion to:
> + *
> + * Windows Server 2003R2 SP2 (5.2.3790)
> + *
> + * used to be Windows 2000 (5.0.2195)
> + */
> os.major = lp_parm_int(GLOBAL_SECTION_SNUM,
> "spoolss", "os_major", 5);
> - /* Windows 2000 == 5.0 */
> os.minor = lp_parm_int(GLOBAL_SECTION_SNUM,
> - "spoolss", "os_minor", 0);
> + "spoolss", "os_minor", 2);
> os.build = lp_parm_int(GLOBAL_SECTION_SNUM,
> - "spoolss", "os_build", 2195);
> + "spoolss", "os_build", 3790);
> os.extra_string = ""; /* leave extra string empty */
>
> ndr_err = ndr_push_struct_blob(&blob, mem_ctx, &os,
> --
> 2.10.2
>
More information about the samba-technical
mailing list