[PATCH] Fix memory leak when destructors reparent talloc child.

Andrew Bartlett abartlet at samba.org
Thu May 5 18:11:06 UTC 2016


On Thu, 2016-05-05 at 10:20 -0700, Jeremy Allison wrote:
> On Fri, May 06, 2016 at 05:15:40AM +1200, Andrew Bartlett wrote:
> > On Wed, 2016-05-04 at 15:24 -0700, Jeremy Allison wrote:
> > > Great catch from Saji VR <saji.vr at nutanix.com> !
> > > 
> > > Can I get a second Team reviewer ?
> > 
> > Can we get a test for this?
> > 
> > It should be possible to check for the leak by counting the talloc
> > blocks.
> 
> Sure Andrew, feel free to commit one.

To be clear, what I'm suggesting is adding such a test to:

https://git.samba.org/?p=samba.git;a=blob_plain;f=lib/talloc/testsuite.
c;hb=HEAD

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba






More information about the samba-technical mailing list