[PATCH] Re: [PATCHES] fix ASN.1 and control syntax for VLV
Douglas Bagnall
douglas.bagnall at catalyst.net.nz
Thu Mar 10 21:48:52 UTC 2016
thanks Jeremy,
>> + cookie = ldb_base64_encode(mem_ctx,
>> + rep_control->contextId,
>> + rep_control->ctxid_len);
>> +
>
> Doesn't this need a check for NULL return from ldb_base64_encode() ?
Patch attached.
>> char *cookie;
>> - const uint8_t *c = (uint8_t*) rep_control->contextId;
>>
>> cookie = ldb_base64_encode(mem_ctx,
>> - rep_control->contextId,
>> + (char *)rep_control->contextId,
>> rep_control->ctxid_len);
>
> And here...
>
It turns out this is the same line.
thanks
Douglas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ldb-controls-don-t-ignore-memory-allocation-failure.patch
Type: text/x-diff
Size: 965 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160311/3f0ba3ae/0001-ldb-controls-don-t-ignore-memory-allocation-failure.diff>
More information about the samba-technical
mailing list