[PATCHES] smb3 create replay (for multi-channel)

Jeremy Allison jra at samba.org
Thu Mar 3 00:45:22 UTC 2016


On Wed, Mar 02, 2016 at 10:45:11PM +0100, Michael Adam wrote:
> On 2016-03-02 at 13:28 -0800, Jeremy Allison wrote:
> > On Wed, Mar 02, 2016 at 09:54:04PM +0100, Michael Adam wrote:
> > > On 2016-03-02 at 12:05 -0800, Jeremy Allison wrote:
> > > > On Tue, Mar 01, 2016 at 02:15:33AM +0100, Michael Adam wrote:
> > > > > 
> > > > > here is an important step toward multi channel:
> > > > > Implementation of create replay.
> > > > > 
> > > > > 
> > > > > Review appreciated.
> > > > 
> > > > LGTM - with the first (already applied) patches
> > > > removed ! Pushed.
> > > 
> > > Thanks a lot Jeremy!
> > > 
> > > I was about to push an updated patchset with the
> > > already pushed patches removed, a few cosmetic
> > > cleanups and more importantly, some additional
> > > new torture tests and (fairly minor) adaptions
> > > of the server code for the corner cases.
> > > 
> > > Since your build has not been started, would
> > > you like me to send a follow up patch or
> > > would you consider pushing a revised patchset
> > > over your currently waiting autobuild?
> > 
> > Sure, send me the revised and the follow-up...
> 
> Attached find the updated patchset.
> Differences with the original one:
> 
> - some cosmetic clean-up of commit messages
>   and test names
> - added three new tests:
>   - replay-dht2-oplock-lease
>     (create with oplock, replay with lease)
>   - replay-dht2-lease-oplock
>     (create with lease, replay with oplock)
>   - replay-dht2-lease3
>     (replay with a different lease key)
> - fixed treatment of leases in create replay
>   in corner cases

Pushing this, but autobuild is failing with:

[252(789)/1892 at 20m43s] samba3.blackbox.smbclient_machine_auth.plain (nt4_member:local)
ERROR: Testsuite[samba3.blackbox.smbclient_machine_auth.plain (nt4_member:local)]
REASON: unable to set up environment nt4_member:local - exiting

Don't think this is to do with your new code.

I'll keep trying tomorrow.



More information about the samba-technical mailing list