[PATCH] [WIP] Attempt to address flapping tests and file/directory mixups

Andrew Bartlett abartlet at samba.org
Sat Jul 23 06:56:26 UTC 2016


On Fri, 2016-07-22 at 15:54 -0700, Jeremy Allison wrote:
> On Fri, Jul 22, 2016 at 03:21:56PM -0700, Jeremy Allison wrote:
> > On Fri, Jul 22, 2016 at 11:23:36PM +1200, Andrew Bartlett wrote:
> > > 
> > > I still think the patch is correct, because relying on general
> > > -purpose
> > > Samba (rather than this module) also re-setting everything in an
> > > EA at
> > > open (when the OS already handles this in the real world) is
> > > silly. 
> > >  However, it still won't help smbclient_tar in my view.
> > 
> > Let me fix it up and remove the rather drastic smb_panic()
> > I added, and I'll repost for you to review with a view to
> > adding to master.
> 
> Here it is. Please review and push if happy !

Pushed.

Now just to send all the tests touching local_path off to distinct
environments...

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba






More information about the samba-technical mailing list