[PATCH] Address regression in bug 11991 and remove s4/spoolss

Andrew Bartlett abartlet at samba.org
Sat Jul 16 10:14:16 UTC 2016


This patch addresses the regression in bug 11991 where the AD DC fails
to start due to incorrectly still including spoolss in 'rpc server
services' after it was disabled for non-ntvfs builds.

It also transpires that the code is simply untested, and as clearly
there is never going to be development of this second spoolss server, I
include a patch to remove it.

I also incorrectly assumed that eventlog6 was similarly a duplicate,
for which I can only apologise.  It is largely a stub to make dcdiag
not fail, but isn't a duplicate.

Please review/push!

Andrew Bartlett
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-build-Always-build-eventlog6.-This-is-not-a-duplicat.patch
Type: text/x-patch
Size: 1092 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160716/c2197892/0001-build-Always-build-eventlog6.-This-is-not-a-duplicat-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-docs-Correct-the-defaults-for-dcerpc-endpoint-servic.patch
Type: text/x-patch
Size: 3377 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160716/c2197892/0002-docs-Correct-the-defaults-for-dcerpc-endpoint-servic-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Remove-unused-and-untested-source4-ntptr-and-spoolss.patch
Type: text/x-patch
Size: 113171 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160716/c2197892/0003-Remove-unused-and-untested-source4-ntptr-and-spoolss-0001.bin>


More information about the samba-technical mailing list