[WIP][PATCH] selftest: add clusteredmember (1-node) env

Ralph Boehme slow at samba.org
Thu Jul 14 09:53:41 UTC 2016


Hi Michael,

great work!

On Wed, Jul 13, 2016 at 02:52:02AM +0200, Michael Adam wrote:
> On 2016-07-13 at 10:25 +1000, Martin Schwenke wrote:
> > Hi Michael,
> > 
> > On Tue, 12 Jul 2016 16:41:11 +0200, Michael Adam <obnox at samba.org>
> > wrote:
> > 
> > > here is the current WIP state of my clusteredmember
> > > selftest environment.
> > >
> > > [...]
> > >
> > > But I appreciate any comments / hints!
> > 
> > I'm working on trying to understand this to see what common code we can
> > use between this and ctdb/tests/simple/scripts/local_daemons.bash.  I
> > figure we should be able to factor out all of the CTDB provisioning
> > code...
> 
> Yeah in the long run, that might be the way to go.
> 
> But since this version of the patch seems to work
> reliably for me now, we might want to bring it
> upstream first and refactor later.

works until it breaks. :)

I have a pending patch that fixes restarting cleanupd in a cluster on
a node that is banned.

Branch with the fix, your patches and an added test for my patch on
top:
<https://git.samba.org/?p=slow/samba.git;a=shortlog;h=refs/heads/cleanupd>

On my system configured with --prefix=/opt/samba this breaks at:

$ make test TESTS=ctdb_ban
...
UNEXPECTED(failure):
samba3.blackbox.ctdb_ban(clusteredmember:local).ctdb_ban(clusteredmember:local)
REASON: Exception: Exception: ../ctdb/client/ctdb_client.c:293 Failed
to connect client socket to daemon. Errno:No such file or directory(2)
../ctdb/common/cmdline.c:167 Failed to connect to daemon
Failed to init ctdb
Failed to read nodes file "/opt/samba/etc/ctdb/nodes"
Is this node part of a CTDB cluster?

^CTOP 10 slowest tests
ERROR: test failed with exit code -2
Makefile:17: recipe for target 'test' failed
make: *** [test] Error 254

Guess we're still missing your patches for ctdb build with a prefix !=
/usr ?

Cheerio!
-slow



More information about the samba-technical mailing list