[PATCH] Fix for bug 11684
Jeremy Allison
jra at samba.org
Thu Jan 21 21:06:37 UTC 2016
On Thu, Jan 21, 2016 at 09:25:53PM +0100, Michael Adam wrote:
> On 2016-01-21 at 20:50 +0100, Volker Lendecke wrote:
> > On Thu, Jan 21, 2016 at 08:45:42PM +0100, Ralph Boehme wrote:
> > > > {} is non-standard, other compilers will not accept this.
> > >
> > > We use it all over the place.
> >
> > Ok, sorry for the noise. We should go through and convert
> > all the {0} that we already have to {}. We should at least
> > be consistent.
>
> From a quick git grep, we seem to use
>
> - { 0 } in 91 places
> - { 0, } in 72 places
> - { } in 7 places
>
> So yes, we should systematize, but probably not to {} ... :-)
As I recall, the (broken) gcc version we have wants a sub-{}
for every internal struct inside the struct we're initializing.
That correct ? If so, we could just fix the inits to have
these for now.
What version of gcc should we be using that fixes the {0}
bug ?
More information about the samba-technical
mailing list