[PATCH] Fix for bug 11684

Jeremy Allison jra at samba.org
Thu Jan 21 21:04:00 UTC 2016


On Thu, Jan 21, 2016 at 08:50:16PM +0100, Volker Lendecke wrote:
> On Thu, Jan 21, 2016 at 08:45:42PM +0100, Ralph Boehme wrote:
> > > {} is non-standard, other compilers will not accept this.
> > 
> > We use it all over the place.
> 
> Ok, sorry for the noise. We should go through and convert
> all the {0} that we already have to {}. We should at least
> be consistent.

I agree. Once we're consistent then we can change to
be standards correct in one swoop when we've got a
working gcc.

But this is orthoganal to the original fix (the
{0} is in the test code Ralph added to ensure
we don't regress).

Can Ralph push the bugfix and (admittedly broken)
test code and then we can decide how to deal with
this afterwards ?

Cheers,

	Jeremy.



More information about the samba-technical mailing list