Fixing OSX remote arch detection

[Justin Maggard]

On Wed, Jan 13, 2016 at 11:53 PM, Volker Lendecke
<Volker.Lendecke at sernet.de> wrote:
> On Wed, Jan 13, 2016 at 05:43:33PM -0800, Justin Maggard wrote:
>> OSX has been getting detected as Vista, for a while now.  Fortunately,
>> it appears to advertise a unique protocol list, so we should be able to
>> detect it easily.  However, I was having trouble deciphering the cryptic
>> method of doing remote arch detection; so I gave up and rewrote it in a
>> way that I (and hopefully others) can understand more easily. :-)
>>
>> I tested locally on the various platforms I have handy (OSX El Capitan,
>> WinNT 4, Win10, Samba/smbclient, and CIFSFS), and did not find any
>> regressions.
>
> Does OS/X always start with a SMB1-style negprot? This would fall over
> if it eventually starts with just an SMB2 negprot.
>

Yes, I tried mounting a few different ways, and OSX always started
with a SMB1-style negprot.  I understand that if they change their SMB
client to skip SMB1 negprot (like CIFSFS does when specifying SMB2 or
3), this will no longer work; but I don't know of an alternative.

-Justin