[PATCH] Fix pwdLastSet behaviour in regards to Windows

Stefan Metzmacher metze at samba.org
Tue Feb 23 06:12:46 UTC 2016


Hi Andrew,

> On Wed, 2016-02-17 at 14:14 +1300, adrianc at catalyst.net.nz wrote:
>> +           && (!io->n.nt_hash) && (!io->n.lm_hash) && (lm_hash)) {
> 
> Just a quick note to the list to say that while most of this patch
> looks OK (but I need to give it another proper look over), the above
> line concerns me.
> 
> Garming and I will sort this one out when we get some time.

Please have a look at my tries at
https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-smart

It starts with
https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=5834ebda238448856fc5536ffd120980cd1b7843
and
https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=78b49053a03f4d255c2854b39b048114262d6f4b
fixes the above problem.

Then
https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=15bf89efc1c3fd532e837334e869141cff4eabe3
is important and used in
https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=239f9ad7e654bf537e18f037d394ffb0034b91ae

Please avoid changing the existing tests, they should continue to work
as is.
And we need new tests which just adds a user with a password on the
ldap_add operation, then pwdLastSet should be non "0" if not explicitly
specified. The new test from Adrian should also be fine.

Thanks!
metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160223/f106f6fb/signature.sig>


More information about the samba-technical mailing list