[PATCH] A few cleanups

Ralph Boehme slow at samba.org
Mon Feb 15 15:07:28 UTC 2016


On Mon, Feb 15, 2016 at 03:56:21PM +0100, Volker Lendecke wrote:
> On Mon, Feb 15, 2016 at 03:34:41PM +0100, Andreas Schneider wrote:
> >     bool ok;
> > 
> >     ok = ads_pull_uint32(ctx->ads, msg_internal, ...
> >     if (ok) {
> 
> Last time I did this Jeremy took this pattern out of a patch of mine
> before pushing, so I think this is not appropriate upstream anymore.

README.Coding is quite clear about this: use helper variables.

Cheerio!
-slow



More information about the samba-technical mailing list