[PATCH] Fix improper use of default interface speed

Michael Adam obnox at samba.org
Sat Feb 13 12:14:46 UTC 2016


On 2016-02-13 at 09:24 +0100, Stefan Metzmacher wrote:
> Am 12.02.2016 um 21:32 schrieb Michael Adam:
> > On 2016-02-12 at 22:16 +0530, Anoop C S wrote:
> >>>>  		}
> >>>>  
> >>>> +		uint64_t if_speed = 1000 * 1000 * 1000; /* 1Gbps
> >>>> */
> >>>
> >>> This should go to the top of the block.
> >>> Declaring the variable inside the block of scope is good,
> >>> but inside the block (just as in functions) the rule
> >>> 'first declaration, then code' holds.
> >>>
> >>
> >> Done. Please see the updated patch.
> > 
> > Reviewed-by: me
> 
> And me, but please file a bug report and add the BUG: ... url to
> the commit message, we also need this in 4.4

Done.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11734

It's in autobuild.

Thanks - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160213/f92e9682/signature.sig>


More information about the samba-technical mailing list