[PATCH][WIP] Make the Samba AD DC multi-process

Andrew Bartlett abartlet at samba.org
Mon Dec 19 22:11:56 UTC 2016


On Mon, 2016-12-19 at 23:03 +0100, Stefan Metzmacher wrote:
> Am 19.12.2016 um 11:36 schrieb Andrew Bartlett:
> > On Thu, 2016-12-15 at 04:00 +1300, Andrew Bartlett wrote:
> > > On Wed, 2016-12-14 at 12:08 +0100, Stefan Metzmacher wrote:
> > > >  
> > > > I've pushed the torture tests alone as I want to make sure we
> > > > already
> > > > pass them (as we should) with the current code.
> > > 
> > > Good idea.  I just ran out of work day to re-order, so thanks!
> > > 
> > > > 
> > > > I'd push the "rpc_server:netlogon Move from memcache to a tdb
> > > > cache"
> > > > patch with the following additions squashed:
> > > > https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=7b1
> > > > 9da5
> > > > 51
> > > > 6a63126cb087403057639cca600fc10
> > > 
> > > Thanks.
> > > 
> > > > 
> > > > Then I'll push the "lsa over netlogon" patches alone.
> > > 
> > > Great.
> > > 
> > > > 
> > > > I still think we should not handle
> > > > DCESRV_INTERFACE_FLAGS_HANDLES_NOT_USED
> > > > in dcesrv_handle_fetch(), if you want to add something
> > > > let dcesrv_handle_new() fail and make sure all callers
> > > > of dcesrv_handle_new() check the return.
> > 
> > I've added an SMB_ASSERT() to both calls.  I hope this is an
> > acceptable
> > approach, otherwise please just ignore this patch, it isn't worth
> > going
> > over and over again compared to the other things we need to sort
> > out
> > this week. 
> 
> Thanks!
> 
> > > > And before calling dcesrv_add_ep() we should
> > > > set e->use_single_process = true if this_model_ops is
> > > > the same as model_ops. If someone uses samba -Msingle
> > > > e->use_single_process should always be true.
> > > 
> > > OK, that makes a little more sense to me now.  Could you do that
> > > for
> > > me?  (Otherwise I'll get to it next week).
> > 
> > I've added that.  Can you please review the attached, or at least
> > indicate I've met your objections?
> 
> Almost, but there're still minor things to fix, see the TODO
> comments in the commit messages.

Thanks.  Sorry for the squash mess - that's what I get for doing
patches at midnight :-)

Andrew Bartlett
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 862 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161220/8b58ef2a/signature.sig>


More information about the samba-technical mailing list