[PATCH] remove xfile.[ch]
Uri Simchoni
uri at samba.org
Sun Dec 11 07:18:49 UTC 2016
On 12/11/2016 12:04 AM, Jeremy Allison wrote:
> On Sat, Dec 10, 2016 at 01:47:51PM -0800, Jeremy Allison wrote:
>> Ah, I think this code has exposed an oooold ooold bug in ntlm_auth.c
>>
>> I don't think this:...
>>
>> static char winbind_separator(void)
>> {
>> struct winbindd_response response;
>> static bool got_sep;
>> static char sep;
>>
>> if (got_sep)
>> return sep;
>>
>> ZERO_STRUCT(response);
>>
>> /* Send off request */
>>
>> if (winbindd_request_response(NULL, WINBINDD_INFO, NULL, &response) !=
>> NSS_STATUS_SUCCESS) {
>> d_printf("could not obtain winbind separator!\n");
>> return *lp_winbind_separator();
>> }
>>
>> should be printing to stdout...
>
> OK - new bug:
>
> https://bugzilla.samba.org/show_bug.cgi?id=12467
>
> Bug 12467 - ntlm_auth can corrupt the output stream with spurious error messages.
>
> Here is the fix. With this patch attached Volker's
> changes pass the previously failing test.
>
> Please review and push if happy !
>
> Cheers,
>
> Jeremy.
>
RB+ me, but since you had an updated commit message on Volker's last
patch, please do the pushin'.. :)
Thanks,
Uri.
More information about the samba-technical
mailing list