resolv_wrapper URI RR support - name compression

[Matt Rogers]

On Tue, 2016-08-23 at 15:54 +0200, Andreas Schneider wrote:
> On Monday, 22 August 2016 17:52:25 CEST Matt Rogers wrote:
> > 
> > Hi,
> > 
> > I'm using resolv_wrapper from master at 02535da4 to test krb5 URI
> > RR
> > lookups. Similar to the SRV records, rwrap_fake_uri() runs
> > ns_name_compress() on the result, however URI records contain a
> > formatted entry and not a DNS name, so I don't think that the call
> > to
> > ns_name_compress() is valid here.  The result of running
> > ns_name_compress() on the URI record (which appears as
> > "krb5srv:m:kkdcp:https://kdc/path") is that it adds a " " to the
> > beginning that does not get removed with a subsequent uncompress.
> > Any
> > objections to removing the ns_name_compress/uncompress on URI RR
> > results?
> 
> This means the provided test is incorrect. We need a test which works
> in a 
> real world scenario and also with resolv_wrapper to verify that
> resolv_wrapper 
> is doing everything correctly.
> 
> Could you use the current test, modify it and make sure it works in
> the real 
> world?
> 
> Then we can fix resolve_wrapper ...
> 

I've attached patches for removing the name compression from the URI
result as well as the tests. This gives a correct result for the real
world test.

Another issue is that it can only return a single answer for a URI
query, since it reaches the first matching URI key in the host file and
stops. The krb5 URI lookup collects all answers from a query and parses
the URIs, sorting the results accordingly, so it would be great to be
able to have a fake hosts file with all of the test URIs listed and not
have to test them one by one.

Matt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: resolv_wrapper-uri-comp.patch
Type: text/x-patch
Size: 1439 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160823/ffee2f29/resolv_wrapper-uri-comp.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: resolv_wrapper-uri-comp-test.patch
Type: text/x-patch
Size: 2684 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160823/ffee2f29/resolv_wrapper-uri-comp-test.bin>