[PATCHES] smbd: allow reading files when only FILE_EXECUTE access is granted

David Disseldorp ddiss at suse.de
Tue Aug 16 09:37:48 UTC 2016


On Tue, 16 Aug 2016 11:02:04 +0300, Uri Simchoni wrote:

...
> Here's an updated patch set which passes with btrfs. Only the "allow
> opening files with arbitrary rights in smb2.ioctl tests" has been
> modified, to be more conservative and not change test behavior for
> previous tests (a single open if possible).

Thanks. I've reviewed and pushed all changes except for the top commit.
The top change looks fine, but I'd nevertheless like an extra set of
eyes on it before pushing.

> The smb2.ioctl test mostly passes against an 2012R2 machine with NTFS -
> 
> 1. The "copy_chunk_src_exceed_multi" fails with
> "../source4/torture/smb2/ioctl.c:1531: bad copy chunk response data"
> 2. The "trim_simple" fails with "../source4/torture/smb2/ioctl.c:4756:
> trim not supported". This is before and after the patch.

I've seen these locally too, and will track them down when I get a
chance.

Cheers, David



More information about the samba-technical mailing list