[PATCH] net: fix a crash with net ads keytab create
Uri Simchoni
urisimchoni at gmail.com
Wed Sep 23 17:32:12 UTC 2015
This patch fix a minor crash with net ads keytab create command.
Thanks,
Uri.
-------------- next part --------------
From 672908c4432ee07e5b58c4f9cf331b1cd3ea59d1 Mon Sep 17 00:00:00 2001
From: Uri Simchoni <urisimchoni at gmail.com>
Date: Wed, 23 Sep 2015 14:45:47 +0300
Subject: [PATCH] net: fix a crash with net ads keytab create
Fix a crash that happens when executing "net ads keytab create"
and the machine account in AD does not have setvice principal names
attached to it.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11528
Signed-off-by: Uri Simchoni <urisimchoni at gmail.com>
---
source3/libads/ldap.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/source3/libads/ldap.c b/source3/libads/ldap.c
index e8ccfa9..1538500 100644
--- a/source3/libads/ldap.c
+++ b/source3/libads/ldap.c
@@ -2076,6 +2076,13 @@ ADS_STATUS ads_get_service_principal_names(TALLOC_CTX *mem_ctx,
res,
"servicePrincipalName",
num_spns);
+ if (*spn_array == NULL) {
+ DEBUG(1, ("Host account for %s does not have service principal "
+ "names.\n",
+ machine_name));
+ status = ADS_ERROR(LDAP_NO_SUCH_OBJECT);
+ goto done;
+ }
done:
ads_msgfree(ads, res);
--
1.9.1
More information about the samba-technical
mailing list