[PATCH] s4:torture:smb2:rename: Fix typo in simple_nodelete testcase. [was: Re: smbtorture typo]
Michael Adam
obnox at samba.org
Wed Sep 16 15:51:35 UTC 2015
On 2015-09-16 at 21:18 +0530, anubhav.rakshit at gmail.com wrote:
> Hi,
>
> Please review.
Thanks!
Reviewed by me.
Who else? - Michael
> thanks,
> anubhav
> On Friday 11 Sep 2015 7:54:40 AM Michael Adam wrote:
> > On 2015-08-06 at 12:45 -0700, Herb Lewis wrote:
> > > Is the following a typo or is there some reason the test was named with an
> > > ending ) ?
> >
> > Hi Herb,
> >
> > I think it is a typo, indeed.
> > I'd happily review a patch.
> >
> > Cheers - Michael
> >
> > > In file source4/torture/smb2/rename.c function torture_smb2_rename_init
> > > we have the following
> > >
> > > torture_suite_add_1smb2_test(suite, "simple_nodelete)",
> > >
> > > torture_smb2_rename_simple2);
> From 28574dfa3999a2d41967c8c4d8135a9d4a620893 Mon Sep 17 00:00:00 2001
> From: Anubhav Rakshit <anubhav.rakshit at gmail.com>
> Date: Wed, 16 Sep 2015 21:04:12 +0530
> Subject: [PATCH] s4:torture:smb2:rename: Fix typo in simple_nodelete testcase.
>
> Signed-off-by: Anubhav Rakshit <anubhav.rakshit at gmail.com>
> ---
> source4/torture/smb2/rename.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> mode change 100644 => 100755 source4/torture/smb2/rename.c
>
> diff --git a/source4/torture/smb2/rename.c b/source4/torture/smb2/rename.c
> old mode 100644
> new mode 100755
> index 07bdabd..23fe4f9
> --- a/source4/torture/smb2/rename.c
> +++ b/source4/torture/smb2/rename.c
> @@ -1403,7 +1403,7 @@ struct torture_suite *torture_smb2_rename_init(void)
> torture_suite_add_1smb2_test(suite, "simple",
> torture_smb2_rename_simple);
>
> - torture_suite_add_1smb2_test(suite, "simple_nodelete)",
> + torture_suite_add_1smb2_test(suite, "simple_nodelete",
> torture_smb2_rename_simple2);
>
> torture_suite_add_1smb2_test(suite, "no_sharing",
> --
> 1.7.0.4
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150916/60425813/attachment.sig>
More information about the samba-technical
mailing list