[PATCH] dynconfig: Fix deps, no talloc required
Andrew Bartlett
abartlet at samba.org
Wed Oct 21 01:54:53 UTC 2015
On Wed, 2015-10-21 at 14:49 +1300, Andrew Bartlett wrote:
> On Mon, 2015-10-12 at 12:18 +0200, Volker Lendecke wrote:
> > Hi!
> >
> > Review&push appreciated!
>
> Volker,
>
> On a host that does not have talloc.h from the system (such as our
> catalyst cloud hosts, or the travis-ci hosts I'm trying to make
> work),
> sadly this breaks the build:
>
> In file included from ../dynconfig/dynconfig.c:21:0:
> ../source4/include/includes.h:54:20: fatal error: talloc.h: No such
> file or directory
> #include <talloc.h>
> ^
> compilation terminated.
> Waf: Leaving directory `/home/ubuntu/autobuild/b13318/samba-libs/bin'
>
> This additional patch fixes that issue, by depending on replace.h
> instead of includes.h (which is thankfully already a dependency in
> waf).
>
> Please review/push!
(and if I had used the magic word 'attached', then my mailer would have
avoided this small embarrassment). Now attached.
Thanks,
Andrew Bartlett
--
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team https://samba.org
Samba Development and Support, Catalyst IT
https://catalyst.net.nz/services/samba
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-dynconfig-Use-replace.h-and-memory.h-directly-not-vi.patch
Type: text/x-patch
Size: 1051 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151021/b3df2cb9/0001-dynconfig-Use-replace.h-and-memory.h-directly-not-vi.bin>
More information about the samba-technical
mailing list